[PATCH] D67377: [PGO][PGSO] ProfileSummary changes.

[Hiroshi Yamauchi via Phabricator via llvm-commits]

yamauchi added inline comments.


================
Comment at: llvm/lib/Analysis/ProfileSummaryInfo.cpp:76
+             "number of blocks required to reach the "
+             "-profile-summary-cutoff-hot percentile exceeds this count."));
+
----------------
tejohnson wrote:
> Should this instead be one of the -pgso-cutoff-* options?
No, this is meant to be like ProfileSummaryHugeWorkingSetSizeThreshold but separately tuned for PGSO to decide whether to have PGSO applied, based on the same profile-summary-cutoff-hot, rather than a different definition of huge working set size that changes based on pgso-cutoff-*. Turning up or down pgso-cutoff-* and choosing whether to having PGSO applied are meant to be independent. Added a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67377/new/

https://reviews.llvm.org/D67377