[llvm] r371473 - Remove some unnecessary REQUIRES: shell lines

[Reid Kleckner via llvm-commits]

I had the same issue initially, but eventually I did `git checkout
llvm/test/MC/AsmParser/preserve-comments-crlf.s` and it went away and I was
no longer able to observe the problem. Once I couldn't see it, I couldn't
debug it anymore.

For the fix, are you sure it's right to treat it as a binary file? Can
.gitattributes appear anywhere in the tree, or does it have to appear in
the root? I thought perhaps that was the issue, see
https://reviews.llvm.org/D67394.

On Tue, Sep 10, 2019 at 5:20 AM Haojian Wu <hokein at google.com> wrote:

> On Tue, Sep 10, 2019 at 7:54 AM via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Hi Reid,
>>
>> Your change seems to have deleted the CRs in the test
>> llvm/trunk/test/MC/AsmParser/preserve-comments-crlf.s which seems to be
>> causing problems for us (and I'm guessing others as well) in the monorepo
>> after merging in that change. Did you intend to remove the CRs in that test?
>>
>> Douglas Yung
>>
>
> I ran into the same issue today (I just ran "git pull" to fetch the latest
> changes, and there was a modified change of that file even though I did not
> change anything in the repo). Dmitri and I
> tracked down it, and hopefully fixed in rL371513.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190910/6b3d8e1e/attachment.html>