[PATCH] D67377: [PGO][PGSO] ProfileSummary changes.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

The abbreviation PGSO is used throughout the code but never defined. Suggest defining it in a few places (e.g. on the new data members and function declarations).



================
Comment at: llvm/include/llvm/Analysis/ProfileSummaryInfo.h:55
   Optional<bool> HasHugeWorkingSetSize;
+  Optional<uint64_t> PgsoHotCountThreshold;
+  Optional<bool> PgsoHasHugeWorkingSetSize;
----------------
Please add comments for these 2 new data members


================
Comment at: llvm/lib/Analysis/ProfileSummaryInfo.cpp:76
+             "number of blocks required to reach the "
+             "-profile-summary-cutoff-hot percentile exceeds this count."));
+
----------------
Should this instead be one of the -pgso-cutoff-* options?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67377/new/

https://reviews.llvm.org/D67377