[PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 08:41:43 PDT 2019


aprantl added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3752
+        LocationInCaller = parse_simple_location(i);
+        break;
+      }
----------------
vsk wrote:
> aprantl wrote:
> > default?
> I don't believe any action is needed in the default case: we do not want to log or report an error.
Doesn't this trigger the switch-doesn't-cover-all-cases warning otherwise?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67376/new/

https://reviews.llvm.org/D67376





More information about the llvm-commits mailing list