[PATCH] D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278).

Tue Sep 10 08:23:50 PDT 2019

jhenderson added a comment.

In D67328#1664573 <https://reviews.llvm.org/D67328#1664573>, @Higuoxing wrote:

> I've tested on my machine, using trunk version of clang. If both object files have one stackmap section, linker just concatenates them into one section. So, this is a bug, right?

llvm-readobj's behaviour is a bug. The linker concatenating them I think is fine behaviour (it's what it does for e.g. .debug_* sections).

> I would like to hard-code the offset as 0x0 in this patch, and improve this behavior in the future. Do you happy with my opinion?

I'd suggest pulling the offset into a local variable, so that you can put a FIXME comment, referencing the bug you mentioned, explaining why the variable is there. That means that the message won't need updating in the future. On the other hand, just a FIXME by the message for now is fine too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67328/new/

https://reviews.llvm.org/D67328