[PATCH] D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.

[Clément Courbet via llvm-commits]

Thanks Sanjay, I've gone for (2): r371522.

On Tue, Sep 10, 2019 at 1:41 PM Sanjay Patel <spatel at rotateright.com> wrote:

>
>
> On Tue, Sep 10, 2019 at 6:54 AM Roman Lebedev via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> On Tue, Sep 10, 2019 at 1:51 PM Clément Courbet via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>> >
>> > I must admit that I only did `ninja check-llvm`, given that I was only
>> touching the backend. It feels weird that I can break clang tests with such
>> changes, is that really intended ?
>> That test is broken, clang codegen tests should not be dependent on
>> llvm middle-end behavior.
>>
>
> Agree, and I've hit this kind of error about many times myself. If
> end-to-end testing is desired, that should go in test-suite.
>
> It would be great if someone active on clang would audit and correct tests
> that run large parts of the IR optimizer (via "-O1" for example).
>
> If not...
> 1. The quick fix is to edit the offending CHECK lines in the test to
> match, and those diffs become part of this patch.
> 2. A slightly better fix is to make the offending CHECK lines vague enough
> that they pass before/after this patch.
>
>
>
>>
>>
>> > On Tue, Sep 10, 2019 at 12:39 PM Dmitri Gribenko via Phabricator <
>> reviews at reviews.llvm.org> wrote:
>> >>
>> >> gribozavr added a comment.
>> >>
>> >> Sorry, this change broke the buildbots:
>> http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/17395,
>> I reverted it (r371507). Please ensure that you run `ninja check-all`
>> before committing.
>> >>
>> >>
>> >> Repository:
>> >>   rG LLVM Github Monorepo
>> >>
>> >> CHANGES SINCE LAST ACTION
>> >>   https://reviews.llvm.org/D60318/new/
>> >>
>> >> https://reviews.llvm.org/D60318
>> >>
>> >>
>> >>
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at lists.llvm.org
>> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190910/adc311b6/attachment.html>