[PATCH] D67366: [CGP] Ensure sinking multiple instructions does not invalidate dominance checks

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 02:38:52 PDT 2019


samparker added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:6206
 
-  SmallPtrSet<Instruction *, 4> MaybeDead;
+  SmallVector<Instruction *, 4> MaybeDead;
+  DenseMap<Instruction *, Instruction *> NewInstructions;
----------------
So it's not possible for an instruction to be inserted multiple times?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67366/new/

https://reviews.llvm.org/D67366





More information about the llvm-commits mailing list