[PATCH] D67060: [Support] Support restoring colors in WithColor
Seiya Nuta via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 10 02:24:53 PDT 2019
seiya marked 4 inline comments as done.
seiya added a comment.
In D67060#1664226 <https://reviews.llvm.org/D67060#1664226>, @ruiu wrote:
> This patch looks good, but I'd add a test for the new code. Is there any place in LLVM where the current color is saved and restored? If there's such code, you can rewrite the code to see if your code would work as expected.
There're no such code AFAIK. How about committing this patch and D65191 <https://reviews.llvm.org/D65191> at once? It will include a test case which depends on this feature.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67060/new/
https://reviews.llvm.org/D67060
More information about the llvm-commits
mailing list