[PATCH] D67388: Add a feature to dump dependency graph.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I looked at the sample provided and I think that if I was a new user, I'd find not clear what is "<internal>" probably.
What about including something like "<internal> is usually a symbol defined by linker" line to the header?

Also I am not sure what is situation now, but before we used to report "<internal>" for linker script defined symbols
in our messages sometimes. Would be nice to have a test for that case.

About printing "-": I am not sure how much it is usefull? Actually it was a bit confusing to see it for me at first. I think if file
is provided by command line it is enough to print "<commandline> <filename>" probably.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67388/new/

https://reviews.llvm.org/D67388