[llvm] r371473 - Remove some unnecessary REQUIRES: shell lines

via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 9 22:54:20 PDT 2019 

Hi Reid,

Your change seems to have deleted the CRs in the test llvm/trunk/test/MC/AsmParser/preserve-comments-crlf.s which seems to be causing problems for us (and I'm guessing others as well) in the monorepo after merging in that change. Did you intend to remove the CRs in that test?

Douglas Yung

-----Original Message-----
From: llvm-commits <llvm-commits-bounces at lists.llvm.org> On Behalf Of Reid Kleckner via llvm-commits
Sent: Monday, September 9, 2019 17:07
To: llvm-commits at lists.llvm.org
Subject: [llvm] r371473 - Remove some unnecessary REQUIRES: shell lines

Author: rnk
Date: Mon Sep  9 17:06:52 2019
New Revision: 371473

URL: http://llvm.org/viewvc/llvm-project?rev=371473&view=rev
Log:
Remove some unnecessary REQUIRES: shell lines

This means these tests will run on Windows. Replace one with
UNSUPPORTED: system-windows.

Modified:
    llvm/trunk/test/Linker/datalayout.ll
    llvm/trunk/test/MC/AsmParser/preserve-comments-crlf.s
    llvm/trunk/test/MC/ELF/comp-dir.s
    llvm/trunk/test/Other/lit-unicode.txt
    llvm/trunk/test/tools/llvm-cov/copy_block_helper.m
    llvm/trunk/test/tools/llvm-cov/cov-comdat.test
    llvm/trunk/test/tools/llvm-cov/gcov47_compatibility.cpp
    llvm/trunk/test/tools/llvm-cov/range_based_for.cpp
    llvm/trunk/test/tools/llvm-dwp/X86/dwos_list_from_exec_simple.test

Modified: llvm/trunk/test/Linker/datalayout.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/datalayout.ll?rev=371473&r1=371472&r2=371473&view=diff
==============================================================================
--- llvm/trunk/test/Linker/datalayout.ll (original)
+++ llvm/trunk/test/Linker/datalayout.ll Mon Sep  9 17:06:52 2019
@@ -1,6 +1,7 @@
-; REQUIRES: shell
-; RUN: llvm-link %s %S/Inputs/datalayout-a.ll -S -o - 2>%t.a.err -; RUN: (echo foo ;cat %t.a.err) | FileCheck --check-prefix=WARN-A %s
+;   Ensure t.a.err is non-empty.
+; RUN: echo foo > %t.a.err
+; RUN: llvm-link %s %S/Inputs/datalayout-a.ll -S -o - 2>>%t.a.err ; 
+RUN: FileCheck --check-prefix=WARN-A %s < %t.a.err
 
 ; RUN: llvm-link %s %S/Inputs/datalayout-b.ll -S -o - 2>%t.b.err  ; RUN: cat %t.b.err | FileCheck --check-prefix=WARN-B %s

Modified: llvm/trunk/test/MC/AsmParser/preserve-comments-crlf.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AsmParser/preserve-comments-crlf.s?rev=371473&r1=371472&r2=371473&view=diff
==============================================================================
--- llvm/trunk/test/MC/AsmParser/preserve-comments-crlf.s (original)
+++ llvm/trunk/test/MC/AsmParser/preserve-comments-crlf.s Mon Sep  9 
+++ 17:06:52 2019
@@ -1,14 +1,13 @@
-	#REQUIRES: shell
-	#RUN: llvm-mc -preserve-comments -n -triple i386-linux-gnu < %s > %t
-	#RUN: diff -b %s %t
-	.text
-
-foo:	#Comment here
-	#comment here
-	nop
-	#if DIRECTIVE COMMENT
-	## WHOLE LINE COMMENT
-	cmpl	$196, %eax	## EOL COMMENT
-	#endif
-	.ident	"clang version 3.9.0"
-	.section	".note.GNU-stack","", at progbits
+	#RUN: llvm-mc -preserve-comments -n -triple i386-linux-gnu < %s > %t
+	#RUN: diff -b %s %t
+	.text
+
+foo:	#Comment here
+	#comment here
+	nop
+	#if DIRECTIVE COMMENT
+	## WHOLE LINE COMMENT
+	cmpl	$196, %eax	## EOL COMMENT
+	#endif
+	.ident	"clang version 3.9.0"
+	.section	".note.GNU-stack","", at progbits

Modified: llvm/trunk/test/MC/ELF/comp-dir.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/comp-dir.s?rev=371473&r1=371472&r2=371473&view=diff
==============================================================================
--- llvm/trunk/test/MC/ELF/comp-dir.s (original)
+++ llvm/trunk/test/MC/ELF/comp-dir.s Mon Sep  9 17:06:52 2019
@@ -1,4 +1,6 @@
-// REQUIRES: shell
+// Don't try to make symlinks on Windows.
+// UNSUPPORTED: system-windows
+//
 // RUN: llvm-mc -triple=x86_64-linux-unknown -g -fdebug-compilation-dir=/test/comp/dir %s -filetype=obj -o %t.o  // RUN: llvm-dwarfdump -v -debug-info %t.o | FileCheck %s
 

Modified: llvm/trunk/test/Other/lit-unicode.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/lit-unicode.txt?rev=371473&r1=371472&r2=371473&view=diff
==============================================================================
--- llvm/trunk/test/Other/lit-unicode.txt (original)
+++ llvm/trunk/test/Other/lit-unicode.txt Mon Sep  9 17:06:52 2019
@@ -1,3 +1,5 @@
+FIXME: See if we can fix this in lit by using Unicode strings.
 REQUIRES: shell
+
 RUN: echo "ようこそ" | FileCheck %s
 CHECK: {{^}}ようこそ{{$}}

Modified: llvm/trunk/test/tools/llvm-cov/copy_block_helper.m
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-cov/copy_block_helper.m?rev=371473&r1=371472&r2=371473&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-cov/copy_block_helper.m (original)
+++ llvm/trunk/test/tools/llvm-cov/copy_block_helper.m Mon Sep  9 
+++ 17:06:52 2019
@@ -1,8 +1,8 @@
 // Make sure that compiler-added functions (whose line number is zero) don't  // crash llvm-cov.
 
-// We need shell for cd
-// REQUIRES: shell
+
+
 
 // RUN: rm -rf %t
 // RUN: mkdir %t

Modified: llvm/trunk/test/tools/llvm-cov/cov-comdat.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-cov/cov-comdat.test?rev=371473&r1=371472&r2=371473&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-cov/cov-comdat.test (original)
+++ llvm/trunk/test/tools/llvm-cov/cov-comdat.test Mon Sep  9 17:06:52 
+++ 2019
@@ -1,5 +1,3 @@
-REQUIRES: shell
-
 # The binary contains two (merged) covmap sections which  # have duplicate CovMapRecords from comdat (template instantation).
 # This test makes sure the reader reads it properly. It also

Modified: llvm/trunk/test/tools/llvm-cov/gcov47_compatibility.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-cov/gcov47_compatibility.cpp?rev=371473&r1=371472&r2=371473&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-cov/gcov47_compatibility.cpp (original)
+++ llvm/trunk/test/tools/llvm-cov/gcov47_compatibility.cpp Mon Sep  9 
+++ 17:06:52 2019
@@ -5,8 +5,8 @@
 // -coverage -Xclang -coverage-no-function-names-in-data
 // -Xclang -coverage-cfg-checksum -Xclang -coverage-version='407*'
 
-// We need shell for cd
-// REQUIRES: shell
+
+
 
 // RUN: rm -rf %t
 // RUN: mkdir %t

Modified: llvm/trunk/test/tools/llvm-cov/range_based_for.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-cov/range_based_for.cpp?rev=371473&r1=371472&r2=371473&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-cov/range_based_for.cpp (original)
+++ llvm/trunk/test/tools/llvm-cov/range_based_for.cpp Mon Sep  9 
+++ 17:06:52 2019
@@ -1,8 +1,8 @@
 // Make sure that compiler-added local variables (whose line number is zero)  // don't crash llvm-cov.
 
-// We need shell for cd
-// REQUIRES: shell
+
+
 
 // RUN: rm -rf %t
 // RUN: mkdir %t

Modified: llvm/trunk/test/tools/llvm-dwp/X86/dwos_list_from_exec_simple.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwp/X86/dwos_list_from_exec_simple.test?rev=371473&r1=371472&r2=371473&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-dwp/X86/dwos_list_from_exec_simple.test (original)
+++ llvm/trunk/test/tools/llvm-dwp/X86/dwos_list_from_exec_simple.test 
+++ Mon Sep  9 17:06:52 2019
@@ -1,5 +1,3 @@
-REQUIRES: shell
-
 RUN: rm -rf %t
 RUN: mkdir %t
 RUN: cd %t


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

More information about the llvm-commits mailing list