[PATCH] D67088: [PowerPC] extend PPCPreIncPrep Pass for ds/dq form

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 9 19:25:18 PDT 2019


hfinkel added a comment.

In D67088#1663072 <https://reviews.llvm.org/D67088#1663072>, @shchenz wrote:

> @hfinkel  Hi Hal, sorry for  pushing you on this issue. Could you give some comments for this patch? As I tested on Power9, the patch gains 9.6% on cpu2017 benchmark exchanges, 2.0% on benchmark x264 for base rate, for peak rate, gains 2.1% on cactuBSSN and 1.9% on xalancbmk. Thanks.


Sorry for the delay. Yes, this looks like a reasonable approach. It will be easier to review, however, if you post the patch without the file renaming (even if you do the renaming on commit) so that it's easier to see what's changing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67088/new/

https://reviews.llvm.org/D67088





More information about the llvm-commits mailing list