[llvm] r371129 - [ADT] Add makeArrayRef(std::array<>) template specialization

[David Blaikie via llvm-commits]

Looks good to me - thanks!

On Mon, Sep 9, 2019 at 5:31 PM Jan Korous <jkorous at apple.com> wrote:
>
> Sure! Thanks for pinging me.
>
> Is this one good enough or do you have any particular scenario on mind?
>
> 79707ecd7d9 [llvm][ADT][NFC] Add test for makeArrayRef(std::array)
>
>
> Jan
>
> > On Sep 9, 2019, at 3:21 PM, David Blaikie <dblaikie at gmail.com> wrote:
> >
> > Could you add some test coverage for this? (I know it's a simple
> > enough function - but good to have a unit test)
> >
> > On Thu, Sep 5, 2019 at 2:25 PM Jan Korous via llvm-commits
> > <llvm-commits at lists.llvm.org> wrote:
> >>
> >> Author: jkorous
> >> Date: Thu Sep  5 14:27:25 2019
> >> New Revision: 371129
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=371129&view=rev
> >> Log:
> >> [ADT] Add makeArrayRef(std::array<>) template specialization
> >>
> >> Modified:
> >>    llvm/trunk/include/llvm/ADT/ArrayRef.h
> >>
> >> Modified: llvm/trunk/include/llvm/ADT/ArrayRef.h
> >> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ArrayRef.h?rev=371129&r1=371128&r2=371129&view=diff
> >> ==============================================================================
> >> --- llvm/trunk/include/llvm/ADT/ArrayRef.h (original)
> >> +++ llvm/trunk/include/llvm/ADT/ArrayRef.h Thu Sep  5 14:27:25 2019
> >> @@ -481,6 +481,12 @@ namespace llvm {
> >>     return Vec;
> >>   }
> >>
> >> +  /// Construct an ArrayRef from a std::array.
> >> +  template <typename T, std::size_t N>
> >> +  ArrayRef<T> makeArrayRef(const std::array<T, N> &Arr) {
> >> +    return Arr;
> >> +  }
> >> +
> >>   /// Construct an ArrayRef from an ArrayRef (no-op) (const)
> >>   template <typename T> ArrayRef<T> makeArrayRef(const ArrayRef<T> &Vec) {
> >>     return Vec;
> >>
> >>
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at lists.llvm.org
> >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>