[PATCH] D67262: [git-llvm] Do not reinvent `@{upstream}`

Mon Sep 9 18:27:46 PDT 2019

mehdi_amini added a comment.

I took the responsibility of reverting in r371480, since I approved this revision without anticipating the behavior change.

> To add some more words, previously we could `git checkout -b foo`, hack a bit commit, and run this script. Now this requires additional, long flags. I don't think making a corner case work that nobody noticed being broken for many months is worth making everything more inconvenient for everyone.

This is a very good point. How do we move forward though?
With the migration to GitHub around the corner, I think it'll be important to have `git llvm` behaves as much as possible as thin wrapper on top of `git` (in case you don't know `git llvm push` will be mandatory to push to LLVM on GitHub, as far as I know).

================
Comment at: utils/git-svn/git-llvm:199
-    if not upstream_branch:
-        upstream_branch = 'origin/master'
-
----------------
Losing the fallback here wasn't really intended I guess, or at least it wasn't acknowledged and made explicit in the commit message.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67262/new/

https://reviews.llvm.org/D67262