[PATCH] D64899: AMDGPU/GlobalISel: First pass at attempting to legalize load/stores

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:605
+    if (NumRegs == 3) {
+      if (!ST.hasDwordx3LoadStores())
+        return true;
----------------
You can combine two conditions into a single if.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:1286
 
-  return VT.bitsGT(MVT::i32) && Align % 4 == 0;
+  return Size >= 32 && Align % 4 == 0;
+}
----------------
"Align > 4"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64899/new/

https://reviews.llvm.org/D64899