[PATCH] D67121: [TargetLowering] Make allowsMemoryAccess methode virtual.

Mon Sep 9 09:50:58 PDT 2019

arsenm added a comment.

In D67121#1663397 <https://reviews.llvm.org/D67121#1663397>, @arsenm wrote:

> In D67121#1656980 <https://reviews.llvm.org/D67121#1656980>, @jmolloy wrote:
>
> > > On the other hand, I don't really want to spend much time thinking about how to make SelectionDAG better at this point.
> >
> > I agree, that's kind of my worry with opening this pandora's box. Changing hooks in SDAG and maintaining performance parity is very hard, and we have a longer term solution in Global Isel.
> >
> > Given that, and given the NFC-ness of this patch, are you happy for it to go in?
>
>
> I'm not happy about it but not too opposed. I'd like someone else's opinion

I would somewhat prefer we split the current function into something like memoryAccessIsLegalForAlignment that has the current behavior, and this would be a separate function defaulting to calling it (Yes, I know this makes the problem worse)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67121/new/

https://reviews.llvm.org/D67121