[PATCH] D67105: [TargetLowering] Fix another potential FPE in expandFP_TO_UINT

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 9 08:51:31 PDT 2019


spatel added inline comments.


================
Comment at: test/CodeGen/X86/vector-constrained-fp-intrinsics.ll:4763
+; CHECK-NEXT:    movsd {{.*#+}} xmm1 = mem[0],zero
+; CHECK-NEXT:    subsd %xmm0, %xmm1
+; CHECK-NEXT:    cvttsd2si %xmm1, %rax
----------------
This looks fine to me given that there's no constant folding yet. 

It is the x86 manifestation of this node:
Creating new node: t15: f64,ch = strict_fsub t0, ConstantFP:f64<4.210000e+01>, ConstantFP:f64<0.000000e+00>



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67105/new/

https://reviews.llvm.org/D67105





More information about the llvm-commits mailing list