[PATCH] D67349: [Inliner][NFC] Make test less brittle.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 9 05:40:37 PDT 2019


courbet created this revision.
courbet added reviewers: RKSimon, qcolombet.
Herald added a project: LLVM.

This tests inlining size thresholds, but relies on the output of running
the full O2 <https://reviews.llvm.org/owners/package/2/> pipeline, making it brittle against changes in unrelated
passes.

Only run the inlining pass and set thresholds on the test RUN line
instead.

Found while investigating D60318 <https://reviews.llvm.org/D60318>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D67349

Files:
  llvm/test/Transforms/Inline/inline_minisize.ll


Index: llvm/test/Transforms/Inline/inline_minisize.ll
===================================================================
--- llvm/test/Transforms/Inline/inline_minisize.ll
+++ llvm/test/Transforms/Inline/inline_minisize.ll
@@ -1,4 +1,4 @@
-; RUN: opt -O2 -S < %s | FileCheck %s
+; RUN: opt -inline -inline-threshold=225 -inlinehint-threshold=360 -S < %s | FileCheck %s
 
 @data = common global i32* null, align 8
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67349.219326.patch
Type: text/x-patch
Size: 416 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190909/dba8d2af/attachment.bin>


More information about the llvm-commits mailing list