[PATCH] D66413: [ARM} Add support for MVE vmaxv

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:1064
     return false;
+  case Instruction::ICmp:
   case Instruction::Add:
----------------
samtebbs wrote:
> samparker wrote:
> > Is this actually needed for codegen?
> It is, as otherwise the smax and umax vector reductions aren't generated and can't be selected on.
As in, the reductions get expanded somewhere and your tests would fail?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66413/new/

https://reviews.llvm.org/D66413