[PATCH] D67286: [Attributor] Implement "noalias" callsite argument deduction

Mon Sep 9 02:53:59 PDT 2019

uenoku marked 2 inline comments as done.
uenoku added inline comments.

================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2644
+                                    : "no-capture-maybe-returned"));
   }

----------------
jdoerfert wrote:
> I do not understand these changes. Why do they help? Can we extract them into a different commit?
I used an internal attribute to look at deduction but anyway I don't need anymore. 
However, I think we need to check whether the value is an argument or not. (D67342)

================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2914
+      indicatePessimisticFixpoint();
+  }
+
----------------
jdoerfert wrote:
> Again, why is this needed?
I encountered a runtime exception in test/Transform/FunctionAttrs/misc.ll. Once I added this check as a solution but now I find that it works well without the check.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67286/new/

https://reviews.llvm.org/D67286