[PATCH] D67288: [Alignment] Use Align for TargetLowering::MinStackArgumentAlignment

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1908
 
   if (Align > TLI.getMinStackArgumentAlignment()) {
     VAList = getNode(ISD::ADD, dl, VAList.getValueType(), VAList,
----------------
I think what the code is trying to express here reads better as:

```
const MaybeAlign MaybeAlign
...
if (MaybeAlign && MaybeAlign.value() > TLI.getMinStackArgumentAlignment()) {
...
}
```

(same below)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67288/new/

https://reviews.llvm.org/D67288