[PATCH] D67343: [DebugInfo] Change object::RelocationResolver to return Expected<uint64_t>

Mon Sep 9 02:41:50 PDT 2019

mstorsjo added inline comments.

================
Comment at: lld/ELF/DWARF.cpp:60
 template <class RelTy> struct LLDRelocationResolver {
   // In the ELF ABIs, S sepresents the value of the symbol in the relocation
   // entry. For Rela, the addend is stored as part of the relocation entry.
----------------
Unrelated to this (but you seem to be fixing variable lowercasing in a comment below); S here (and A in the comment below below) are also left behind upper cased here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67343/new/

https://reviews.llvm.org/D67343