[PATCH] D67340: [Object] Implement relocation resolver for COFF ARM/ARM64

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Object/RelocationResolver.cpp:443
+  case COFF::IMAGE_REL_ARM_ADDR32:
+    return (S + A) & 0xFFFFFFFF;
+  default:
----------------
mstorsjo wrote:
> ruiu wrote:
> > Is it OK to silently wrap-around an overflowed value? I wonder if we should report an error.
> Not sure if the base values will be in range where overflow might even be expected.
> 
> In any case, this is the exact same existing code matching `resolveCOFFX86` and `resolveCOFFX86_64` (see the context of the diff), just with different arch-specific relocation names.
Ah, OK. There precedents there in this file indeed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67340/new/

https://reviews.llvm.org/D67340