[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

In D59754#1656217 <https://reviews.llvm.org/D59754#1656217>, @leonardchan wrote:

> Hi! We've noticed that for our arm bots, we're getting some flaky builds that sometimes fail with `error: array designators are a C99 extension [-Werror,-Wc99-designator]` and sometimes don't fail. 2 questions:
>
> 1. I can't see it off the patch immediately, but do you know why for arm specifically we can only get this warning sometimes?
> 2. I noticed that for the `test/SemaCXX/c99.cpp` test, this warning is also diagnosed for the `-std=c++17` case. Are C-style designated initializers only invalid in c++20, or are they also invalid in 17?
>
>   Thanks.


@rsmith ping? We're still hitting this issue in our build. Should this warning be diagnosed even when using `-std=c++17`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59754/new/

https://reviews.llvm.org/D59754