[PATCH] D67298: [ASan] Only run dlopen-mixed-c-cxx.c with static runtime

Sun Sep 8 04:37:33 PDT 2019

Hahnfeld added a comment.

In D67298#1662222 <https://reviews.llvm.org/D67298#1662222>, @serge-sans-paille wrote:

> Successfully tested on my box! I'd just use
>
>   diff
>    - UNSUPPORTED: asan-dynamic-runtime
>    +REQUIRES: x86_64-target-arch && !android && !asan-dynamic-runtime
>   
>
> if that works on your side too.

Can you elaborate why you think we need to restrict this case? I don't see anything that only works on x86_64 or that cannot work per se on Android. I'd guess that these annotations were added as bots complained (because the test was running in an unintended configuration).

If there's no good reason, I'd strongly oppose to adding the `REQUIRES`. We should keep tests as broad as possible to maximize the likelihood that it fails if someone breaks this (or a similar) case in the future.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67298/new/

https://reviews.llvm.org/D67298