[PATCH] D67053: [LLD] [COFF] Resolve source locations for undefined references using dwarf

Sat Sep 7 23:56:48 PDT 2019

mstorsjo added a comment.

In D67053#1662274 <https://reviews.llvm.org/D67053#1662274>, @MaskRay wrote:

> In D67053#1662244 <https://reviews.llvm.org/D67053#1662244>, @mstorsjo wrote:
>
> > Reduced the size of the test case by manually cutting out unneeded parts, similar to some of the ELF tests.
>
>
> The updated test looks good now. Have you had success with larger executables now?

Yes, it works fine in large test cases as well.

Do you have an opinion on whether I should keep the LLVMSymbolizer object around between calls?

And would it be better to use `symbolizeInlinedCode` instead of `symbolizeCode`? (That requires a small patch to the symbolizer, to allow that one to operate on an in-memory object file.)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67053/new/

https://reviews.llvm.org/D67053