[PATCH] D67318: [SimplifyCFG] FoldTwoEntryPHINode(): consider *total* speculation cost, not per-BB cost

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

D67240 <https://reviews.llvm.org/D67240> numbers for RawSpeed: (rL371316 <https://reviews.llvm.org/rL371316> vs. these two patches)

| metric                                 | old    | new    | delta | % change |
| x86-mi-counting.NumMachineFunctions    | 10513  | 10513  | 0     | 0.00%    |
| x86-mi-counting.NumMachineBasicBlocks  | 200350 | 200178 | -172  | -0.09%   |
| x86-mi-counting.NumMachineInstructions | 3307866      | 3305737      | -2129 | -0.06%   |
| x86-mi-counting.NumUncondBR            | 33479  | 33463  | -16   | -0.05%   |
| x86-mi-counting.NumCondBR              | 91062  | 90925  | -137  | -0.15%   |
| x86-mi-counting.NumCMOV                | 4195   | 4276   | 81    | 1.93%    |
| x86-mi-counting.NumVecBlend            | 17     | 17     | 0     | 0.00%    |
|

F9942880: rawspeed-x86-mi-count-0-old.json <https://reviews.llvm.org/F9942880> F9942882: rawspeed-x86-mi-count-1-new.json <https://reviews.llvm.org/F9942882>

This is pretty in-line with what we had in

In D65148#1660471 <https://reviews.llvm.org/D65148#1660471>, @lebedev.ri wrote:

> Numbers for RawSpeed:
>
> | metric                                 | old    | new    | delta | % change |  |
> | x86-mi-counting.NumMachineFunctions    | 10513  | 10513  | 0     | 0.00%    |
> | x86-mi-counting.NumMachineBasicBlocks  | 200350 | 200163 | -187  | -0.09%   |
> | x86-mi-counting.NumMachineInstructions | 3307866      | 3305504      | -2362 | -0.07%   |
> | x86-mi-counting.NumUncondBR            | 33479  | 33465  | -14   | -0.04%   |
> | x86-mi-counting.NumCondBR              | 91062  | 90908  | -154  | -0.17%   |
> | x86-mi-counting.NumCMOV                | 4195   | 4284   | 89    | 2.12%    |
> | x86-mi-counting.NumVecBlend            | 17     | 17     | 0     | 0.00%    |
> |
>
> F9931070: results-old.json <https://reviews.llvm.org/F9931070> F9931071: results-new.json <https://reviews.llvm.org/F9931071>



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67318/new/

https://reviews.llvm.org/D67318