[PATCH] D67318: [SimplifyCFG] FoldTwoEntryPHINode(): consider *total* speculation cost, not per-BB cost

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D67318#1662148 <https://reviews.llvm.org/D67318#1662148>, @xbolva00 wrote:

> >>   4 major improvements


Note that those numbers are for D65148 <https://reviews.llvm.org/D65148>;

In D67318#1662148 <https://reviews.llvm.org/D67318#1662148>, @xbolva00 wrote:

> and no regressions?


See https://reviews.llvm.org/D65148#1602979 for that disscussion.

I have not rerun any of the measurements that were done
in that patch here as of yet, but the results may or may not
be better since this actually speculates //less// instructions.

In D67318#1662148 <https://reviews.llvm.org/D67318#1662148>, @xbolva00 wrote:

> Please also provide test suite numbers.


As i have stated previously, that is not feasible for me,
i have tried and the results are always too noisy,
the tooling there is just too clumsy for me.
If you have working setup please feel free to post noise-less actionable the numbers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67318/new/

https://reviews.llvm.org/D67318