[PATCH] D65945: [LLVM][Alignment] Make functions using log of alignment explicit

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 08:05:58 PDT 2019


gchatelet added a comment.

@lattner I've added you to this review because I get no feedback from the authors (and you seem to be the OWNER).
The rename exposed a bug in the way alignment of basic blocks and function arguments are serialized for YAML mir.
>From this patch <https://github.com/llvm/llvm-project/commit/547a83b4ebd1> and the `parseAlignment` code it is clear that the serialized form expects powers of two, but the internal structures receiving the alignment deal with log2 of alignments (`MachineFunction` and `MachineBasicBlock`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65945/new/

https://reviews.llvm.org/D65945





More information about the llvm-commits mailing list