[PATCH] D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 7 07:07:29 PDT 2019


lebedev.ri added a comment.

In D65148#1662019 <https://reviews.llvm.org/D65148#1662019>, @lebedev.ri wrote:

> In D65148#1661691 <https://reviews.llvm.org/D65148#1661691>, @efriedma wrote:
>
> > ...
>




> In D65148#1661691 <https://reviews.llvm.org/D65148#1661691>, @efriedma wrote:
> 
>> Should we be tying all of them together?

But now i have changed my opinion.

> (2) critical:
>  `FoldTwoEntryPHINode((`

D67318 <https://reviews.llvm.org/D67318>, if makes sense, it effectively replaces this patch.

> (2) critical:
>  `mergeConditionalStoreToAddress((`

I'm not fully sure about this one, not going to touch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65148/new/

https://reviews.llvm.org/D65148





More information about the llvm-commits mailing list