[PATCH] D67317: [PowerPC][NFC] Update test assertions using update_llc_test_checks.py

Xing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 7 06:44:41 PDT 2019


Higuoxing added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/store-combine.ll:238
-; CEHCK-PPC64LE: stdbrx [[REG2]], 0, 4
-; CEHCK-PPC64: stdx [[REG2]], 0, 4
 }
----------------
lkail wrote:
> Higuoxing wrote:
> > Thanks, I'm not familiar with PowerPC instructions. What's your purpose by removing these two check points? It's useless or you will fix the typo later?
> This test has been declared `NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py`. Re-running `update_llc_test_checks.py`, seems these two instructions should not appear. I've also added original author as a reviewer to see if some `CHECK-NOT` directives shall keep or not.
Ok, I got it. Thanks a lot.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67317/new/

https://reviews.llvm.org/D67317





More information about the llvm-commits mailing list