[PATCH] D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 7 03:58:15 PDT 2019


lebedev.ri added a comment.

In D65148#1662019 <https://reviews.llvm.org/D65148#1662019>, @lebedev.ri wrote:

> In D65148#1661691 <https://reviews.llvm.org/D65148#1661691>, @efriedma wrote:
>
> > ...
>
>
> (1) minor:
>  `mergeConditionalStoreToAddress()` uses `PHINodeFoldingThreshold`
>  as instruction count while others actually use it as cost.
>  It should likely actually check the cost, not instruction count.


D67315 <https://reviews.llvm.org/D67315>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65148/new/

https://reviews.llvm.org/D65148





More information about the llvm-commits mailing list