[PATCH] D67310: [ELF][AArch64] Apply some NFC cleanups to AArch64ErrataFix.cpp
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Sep 7 03:16:44 PDT 2019
grimar added inline comments.
================
Comment at: ELF/AArch64ErrataFix.cpp:438
auto isCodeMapSymbol = [](const Symbol *b) {
- return b->getName() == "$x" || b->getName().startswith("$x.");
+ return b->getName().startswith("$x");
};
----------------
MaskRay wrote:
> grimar wrote:
> > It is not a NFC change.
> >
> > This code now accepts `$xfoo`, what wasn't before.
> This is the question I asked in https://reviews.llvm.org/D67284#inline-604486
>
> I'll probably remove NFC from the title. I actually mean this change doesn't intend to make any observable behavior changes, i.e. llvm only generates `"$a"` and `"$t"`, not `"$a."` or `"$xfoo"`.
I see. I do not know the answer here, but all other changes LGTM.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67310/new/
https://reviews.llvm.org/D67310
More information about the llvm-commits
mailing list