[PATCH] D67298: [ASan] Fix test case dlopen-mixed-c-cxx.c without C++ stdlib

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 7 02:58:18 PDT 2019


Hahnfeld added a comment.

In D67298#1661672 <https://reviews.llvm.org/D67298#1661672>, @serge-sans-paille wrote:

> Mmmmh the whole point of the test is to test how asan behaves when meeting a symbol like `__cxa_throw` in a dlopened library when the calling compilation unit is not linked against libstdc++. Previous behavior was a segfault, we should now get a reasonable error.




1. Just noticed that the test accepts `__cxa_{{.*}}throw{{.*}}` which matches `__cxa_rethrow_primary_exception`; even if the test passes I don't have a line with `__cxa_throw`.
2. I don't see a segfault when I remove the added lines in `interception_linux.cpp`.

I think there's something fundamentally wrong and I'd ask you as the author to figure this out. I've just tried and I can reproduce the above when building a standalone version of `compiler-rt` with trunk clang. Let me know if you need more help.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67298/new/

https://reviews.llvm.org/D67298





More information about the llvm-commits mailing list