[PATCH] D67303: [AArch64][GlobalISel] Enable the localizer for optimized builds

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 15:23:52 PDT 2019


aemerson added a comment.

In D67303#1661664 <https://reviews.llvm.org/D67303#1661664>, @qcolombet wrote:

> Hi Amara,
>
> Where are the benefits coming from for optimized build?
>  I am guessing less copies/spills and in that case, I think we should try to fix the allocator, but that's more a long term plan.
>  Fill a PR though with an example so that we don't forget.
>
> LGTM.
>
> Cheers,
> -Quentin


The swifterror test change in this patch is one example. Live ranges over function calls can be problematic if under register pressure, which can cause additional moves, if not spills. There are others of course. The greedy allocator just doesn't seem to expect long live ranges across basic-block boundaries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67303/new/

https://reviews.llvm.org/D67303





More information about the llvm-commits mailing list