[PATCH] D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

That looks mostly fine, then.  Maybe still a few more cmovs than I'd like, still... but close enough.

In terms of the actual code, I have a couple questions I'm trying to understand:

1. It looks like PHINodeFoldingThreshold actually controls multiple SimplifyCFG transforms?  Which transforms are actually providing the improvements you see?  Should we be tying all of them together?
2. For if-converting a triangle, like the testcases, it looks like we're using separate thresholds for the number of speculated instructions, and the number of generated select instructions?  Should we be using some sort of combined cost, instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65148/new/

https://reviews.llvm.org/D65148