[PATCH] D67298: [ASan] Fix test case dlopen-mixed-c-cxx.c without C++ stdlib

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 14:58:35 PDT 2019


serge-sans-paille added a comment.

Mmmmh the whole point of the test is to test how asan behaves when meeting a symbol like `__cxa_throw` in a dlopened library when the calling compilation unit is not linked against libstdc++. Previous behavior was a segfault, we should now get a reasonable error. By defining `__cxa_throw` in the c file, you remove the origin of the bug, so sure it works, but it no longer tests the faulty situation. Maybe tehre's a symbol defined in both libcxx and libstdc++ the same way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67298/new/

https://reviews.llvm.org/D67298





More information about the llvm-commits mailing list