[PATCH] D65350: [DDG] Data Dependence Graph Basics

Fri Sep 6 14:13:22 PDT 2019

bmahjour marked an inline comment as done.
bmahjour added inline comments.

================
Comment at: llvm/docs/DependenceGraphs/DDG.rst:44
+
+.. image:: cycle.png
+
----------------
bmahjour wrote:
> Meinersbur wrote:
> > The patch currently does not apply with arcanist. I only get 0 byte files for these images.
> Sorry I forgot to use `--binary` when creating my patch. I'll fix it.
There seems to be an issue with phabricator showing binary parts of a patch. I can recreate the .png files by reapplying the patch that I uploaded to this revision, but if I "Download Raw Diff" from this revision and apply it the images are null. I see the same issue in other reviews that added images eg. https://reviews.llvm.org/D49433.

For now you can see the images here: https://ibm.box.com/v/data-dependence-graph

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65350/new/

https://reviews.llvm.org/D65350