[PATCH] D67301: [LLD] Unify the demangleItanium and demangleMSVC functions. NFC.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: rnk, ruiu.
Herald added subscribers: erik.pilkington, MaskRay, aheejin, arichardson, sbc100, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

This was requested by @rnk in the review of D67051 <https://reviews.llvm.org/D67051>.

Technically, this isn't totally NFC - now itanium symbols are demangled in the COFF linker without the mingw flag being set, but that's probably ok?

Should the `_` prefix (for itanium symbols in i386 mode) be stripped by the COFF wrapper function, or by the common `demangle` function (matching `_Z` or `__Z`)?

Or did you mean merging the two demangler functions at the llvm level as well?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D67301

Files:
  COFF/Symbols.cpp
  Common/Strings.cpp
  ELF/SymbolTable.cpp
  ELF/Symbols.cpp
  include/lld/Common/Strings.h
  wasm/Symbols.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67301.219167.patch
Type: text/x-patch
Size: 6048 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190906/01e5a4f2/attachment.bin>