[PATCH] D67297: [aarch64] Add combine patterns for fp16 fmla

Sebastian Pop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 12:04:06 PDT 2019


sebpop created this revision.
sebpop added reviewers: SjoerdMeijer, az, evandro, jgreenhalgh, kristof.beyls.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

This patch enables generation of fused multiply add/sub for instructions operating on fp16.
Tested on aarch64-linux.

There are 7 CHECK-FIXME for patterns for which I was not able to create a testcase to exercise the added code paths.
Those 7 patterns are mixing v[4|8]i16 with v[4|8]fp16 types with the help of a bitcast.
I am not sure how to write a testcase without the bitcast, and to generate coverage over those combine patterns,
so I would appreciate help on rewriting those testcases.


https://reviews.llvm.org/D67297

Files:
  llvm/include/llvm/CodeGen/MachineCombinerPattern.h
  llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
  llvm/test/CodeGen/AArch64/fp16-fmla.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67297.219150.patch
Type: text/x-patch
Size: 25635 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190906/bc0d5430/attachment.bin>


More information about the llvm-commits mailing list