[PATCH] D66969: Output XCOFF object text section

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:92
 
   uint16_t Index;
 
----------------
Should this also be int16_t? Since the Index could be negative value it seems. 


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:340
+    const Symbol &SymbolRef, const ControlSection &CSectionRef,
+    const int16_t Index, uint64_t SymbolOffset) {
+  // n_name, n_zeros, n_offset
----------------
jasonliu wrote:
> top level const is not necessary for the Index parameter.
> Should it be uint16_t?
> Nit: Index -> SectionIndex 
> 
sorry, it should be int16_t.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:344
+  W.write<uint32_t>(CSectionRef.Address + SymbolOffset);
+  W.write<int16_t>(Index);
+  // Basic/Derived type. See the description of the n_type field for symbol
----------------
jasonliu wrote:
> int16_t -> uint16_t?
Sorry my bad. It should be int16_t.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66969/new/

https://reviews.llvm.org/D66969