[PATCH] D57836: [Intrinsic] Unsigned Fixed Point Saturation Multiplication Intrinsic

[Leonard Chan via Phabricator via llvm-commits]

leonardchan accepted this revision.
leonardchan added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for taking over this!



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2984
+      SatMax = DAG.getSetCC(dl, BoolNVT, HLAdjusted, NVTZero, ISD::SETNE);
+    }
+    Hi = DAG.getSelect(dl, NVT, SatMax, NVTNeg1, Hi);
----------------
Nit: Add an else case with an `llvm_unreachable` mentioning that we returned earlier when `Scale == VTSize` and that the scale must be less than or equal to the width of the operands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57836/new/

https://reviews.llvm.org/D57836