[PATCH] D67263: [DwarfExpression] Disallow some rewrites to avoid undefined behavior

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope updated this revision to Diff 219131.
bjope added a comment.
Herald added a subscriber: jholewinski.

Now using std::numeric_limits and C++ style casts (thanks JDevlieghere!).

Also updated checks in test/DebugInfo/NVPTX/dbg-declare-alloca.ll. By using DIExpression::appendOffset in DwarfCompileUnit::constructVariableDIEImpl we now get rid of an, afaict, useless "DW_OP_add_uconst 0".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67263/new/

https://reviews.llvm.org/D67263

Files:
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
  llvm/test/DebugInfo/NVPTX/dbg-declare-alloca.ll
  llvm/test/DebugInfo/X86/dw_op_constu.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67263.219131.patch
Type: text/x-patch
Size: 21113 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190906/9890f341/attachment-0001.bin>