[PATCH] D66309: Introduce infrastructure for an incremental port of SelectionDAG atomic load/store handling

[Philip Reames via Phabricator via llvm-commits]

reames marked an inline comment as done.
reames added inline comments.


================
Comment at: include/llvm/CodeGen/TargetLowering.h:3719
+  virtual bool lowerAtomicStoreAsStoreSDNode(const StoreInst &SI) const {
+    assert(SI.isAtomic());
+    return false;
----------------
RKSimon wrote:
> missing assertion message
Happy to add something, but given the naming of the functions, I don't really think (... && "violated precondition") adds anything valuable.

This also feels like a very small nit.  Is there any chance I can get an LGTM and just fix this before the commit?  Refreshing this is a real pain since I have to rebuild the world.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66309/new/

https://reviews.llvm.org/D66309