[PATCH] D67182: [lib/ObjectYAML] - Improve and cleanup error reporting in ELFState<ELFT> class.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/tools/yaml2obj/duplicate-symbol-names.test:44
+# CASE3: error: repeated symbol name: 'localfoo'
+# CASE3: error: repeated symbol name: 'localfoo'
 
----------------
CASE3-COUNT-2:


================
Comment at: test/tools/yaml2obj/dynamic-section-raw-content.yaml:29
 
+# RUN: not yaml2obj --docnum=2 %s -o %t2 2>&1 | FileCheck %s --check-prefix=ERR
+
----------------
Can `-o %t2` be deleted?


================
Comment at: test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml:32
 
-# CASE2: error: Cannot specify both `Size` and `DynamicSymbols` for symbol table section '.dynsym'.
+# RUN: not yaml2obj --docnum=2 %s -o %t2 2>&1 | FileCheck %s --implicit-check-not=error --check-prefix=CASE2
+
----------------
Can `-o %t2` be deleted?


================
Comment at: test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml:56
 
-# CASE3: error: Cannot specify both `Content` and `DynamicSymbols` for symbol table section '.dynsym'.
+# RUN: not yaml2obj --docnum=3 %s -o %t3 2>&1 | FileCheck %s --implicit-check-not=error --check-prefix=CASE3
+
----------------
Can `%t3` be deleted?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67182/new/

https://reviews.llvm.org/D67182