[PATCH] D67286: [Attributor] Implement "noalias" callsite argument deduction

Hideto Ueno via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 09:18:14 PDT 2019


uenoku added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1675
   void initialize(Attributor &A) override {
-    // TODO: It isn't sound to initialize as the same with `AANoAliasImpl`
-    // because `noalias` may not be valid in the current position.
+    if (hasAttr({Attribute::NoAlias}) || isa<AllocaInst>(getAssociatedValue()))
+      indicateOptimisticFixpoint();
----------------
Once I thought it is not sound to do this initialization but, I reconsider that unless we don't manifest the information for floating value, there is no problem. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67286/new/

https://reviews.llvm.org/D67286





More information about the llvm-commits mailing list