[PATCH] D67182: [lib/ObjectYAML] - Improve and cleanup error reporting in ELFState<ELFT> class.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 07:22:38 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with comment fixes



================
Comment at: test/tools/yaml2obj/elf-comdat-broken-members.yaml:1
+## Check we report an error when SHT_GROUP refereces unknown section in its members list.
+
----------------
refereces(typo) unknown -> references an unknown
members list -> member list


================
Comment at: test/tools/yaml2obj/reloc-sec-info.yaml:27
+
+## Check we report an error when relocation section references an unknown section via Info field.
+
----------------
when a relocation section
via its Info


================
Comment at: test/tools/yaml2obj/section-link.yaml:27
+
+## Check we report an error when unknown section is referenced via Link field.
+
----------------
when an unknown
via a Link


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67182/new/

https://reviews.llvm.org/D67182





More information about the llvm-commits mailing list