[PATCH] D67225: [DebugInfo][X86] Describe call site values for zero-valued imms

[Nikola Prica via Phabricator via llvm-commits]

NikolaPrica added a comment.

This looks good! I'm happy to see that implicit operands can be removed from the work-list this efficiently.

>> Having ParamLoadedValue contain a MachineOperand object makes sense to me. This would stave off an explosion of ad hoc OneOperand, TwoOperand, etc forever-objects. And you've demonstrated that the overhead is negligible.
>> 
>> Looking forward, I also think it makes sense to change the describeLoadedValue API s.t. it's specific about which loaded value is interesting. That can wait until there's a motivating test case.
> 
> +1

+1


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67225/new/

https://reviews.llvm.org/D67225