[PATCH] D67192: [X86] Use MOVSX instead of CBW to extend i8 to AX for i8 sdiv.
Andrea Di Biagio via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 6 03:51:37 PDT 2019
andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: ychen.
Looks good to me.
Thanks for the changes in FixupBWInsts. Personally I was already happy with the previous version patch. But this one is looks even better.
I also agree that this change should be split into three commits.
================
Comment at: llvm/lib/Target/X86/X86FixupBWInsts.cpp:242
+ // These are the opcodes currently known to work with the code below, if
+ // something // else will be added we need to ensure that new opcode has the
+ // same properties.
----------------
Extra '//' between 'something' and 'else'
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67192/new/
https://reviews.llvm.org/D67192
More information about the llvm-commits
mailing list