[PATCH] D67218: [AMDGPU] Mark s_barrier as having side effects but not accessing memory.

[Jay Foad via Phabricator via llvm-commits]

foad marked 2 inline comments as done.
foad added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:209
 def int_amdgcn_s_barrier : GCCBuiltin<"__builtin_amdgcn_s_barrier">,
-  Intrinsic<[], [], [IntrConvergent]>;
+  Intrinsic<[], [], [IntrNoMem, IntrHasSideEffects, IntrConvergent]>;
 
----------------
arsenm wrote:
> This does end up not adding readnone to the intrinsic declaration, correct?
The declaration comes out as:
```
; Function Attrs: convergent nounwind
declare void @llvm.amdgcn.s.barrier() #0
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67218/new/

https://reviews.llvm.org/D67218