[PATCH] D67260: [yaml2obj] Set p_align to the maximum sh_addralign of containing sections

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 02:07:58 PDT 2019


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

This LGTM. But please wait a bit to see if others have any comments.



================
Comment at: test/tools/yaml2obj/program-header-align.yaml:32
+
+## If Align: is not specified, p_align is inferred from the maximum alignment
+## of containing sections.
----------------
nit: Excessive ":" here and in the comment above?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67260/new/

https://reviews.llvm.org/D67260





More information about the llvm-commits mailing list